Skip to content

use localSystem to start the service - #34802

Merged
Anipik merged 1 commit into
dotnet:masterfrom
Anipik:service
Apr 10, 2020
Merged

use localSystem to start the service#34802
Anipik merged 1 commit into
dotnet:masterfrom
Anipik:service

Conversation

@Anipik

@Anipik Anipik commented Apr 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #1262

Tested it locally

C:\git\runtime>dotnet msbuild src\libraries\System.ServiceProcess.ServiceController\tests /t:rebuild;test /p:RuntimeConfiguration=release /p:Outerloop=true
    Discovering: System.ServiceProcess.ServiceController.Tests (method display = ClassAndMethod, method display options = None)
    Discovered:  System.ServiceProcess.ServiceController.Tests (found 35 of 37 test cases)
    Starting:    System.ServiceProcess.ServiceController.Tests (parallel test collections = on, max threads = 12)
    Finished:    System.ServiceProcess.ServiceController.Tests
  === TEST EXECUTION SUMMARY ===
     System.ServiceProcess.ServiceController.Tests  Total: 38, Errors: 0, Failed: 0, Skipped: 0, Time: 328.805s

OPened new issue to track the one test being disabled

@Anipik
Anipik requested review from danmoseley and ericstj April 10, 2020 02:43
danmoseley
danmoseley approved these changes Apr 10, 2020
View reviewed changes

@danmoseley danmoseley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the comment in the issue about AutoLog.. it was wrong?

@ericstj

ericstj commented Apr 10, 2020

Copy link
Copy Markdown
Member

What about the comment in the issue about AutoLog.. it was wrong?

I suspect that comment was talking about the test’s default not the system default.

@ericstj

ericstj commented Apr 10, 2020

Copy link
Copy Markdown
Member

OPened new issue to track the one test being disabled

I suspect you caused this by running as SYSTEM. Probably need to explicitly ACL the pipe to let lower privileged process use it.

ericstj
ericstj approved these changes Apr 10, 2020
View reviewed changes

@ericstj ericstj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK. Double check that we didn’t have any tests disabled against that issue. Watch the next outer loop run to ensure it works.

@Anipik

Anipik commented Apr 10, 2020

Copy link
Copy Markdown
Contributor Author

Seems OK. Double check that we didn’t have any tests disabled against that issue. Watch the next outer loop run to ensure it works.

checked.

What about the comment in the issue about AutoLog.. it was wrong?

yes as eric mentioned it was tests default rather than systems default.

I suspect you caused this by running as SYSTEM. Probably need to explicitly ACL the pipe to let lower privileged process use it.

i will try that

@Anipik
Anipik merged commit 98e95d9 into dotnet:master Apr 10, 2020
@Anipik
Anipik deleted the service branch April 10, 2020 15:41
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ericstj ericstj ericstj approved these changes
+1 more reviewer
@danmoseley danmoseley danmoseley approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-System.ServiceProcess

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ServiceController tests fail to start test service

4 participants

@Anipik @ericstj @danmoseley @Dotnet-GitSync-Bot